Skip to content

Conversation

@RunFMe
Copy link

@RunFMe RunFMe commented May 10, 2024

All Submissions Basics:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you checked all Issues to tie the PR to a specific one?

All Submissions Cores:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?
  • Does your submission pass tests, including CircleCI, Travis CI, and AppVeyor?
  • Does your submission have appropriate code coverage? The cutoff threshold is 95% by Coversall.

New Model Submissions:

  • Have you created a .py in ~/pyod/models/?
  • Have you created a _example.py in ~/examples/?
  • Have you created a test_.py in ~/pyod/test/?
  • Have you lint your code locally prior to submission?

@yzhao062
Copy link
Owner

Thanks for the PR -- I will suggest calling it vae_torch.py other than vae.py to directly overwrite the keras one (we will retire the keras version later

@coveralls
Copy link

coveralls commented May 20, 2024

Pull Request Test Coverage Report for Build 9036157911

Details

  • 110 of 117 (94.02%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 93.773%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyod/models/vae.py 108 115 93.91%
Totals Coverage Status
Change from base Build 8309419980: 0.02%
Covered Lines: 9066
Relevant Lines: 9668

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants