Skip to content

Fixed COPOD and ECOD decision function inconsistency with their respective papers #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed COPOD and ECOD decision function inconsistency with their respective papers #562

wants to merge 2 commits into from

Conversation

@Hellsice
Copy link

@Hellsice Hellsice commented Apr 30, 2024

All Submissions Basics:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you checked all Issues to tie the PR to a specific one?

All Submissions Cores:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?
  • Does your submission pass tests, including CircleCI, Travis CI, and AppVeyor?
  • Does your submission have appropriate code coverage? The cutoff threshold is 95% by Coversall.

Hellsice added 2 commits April 30, 2024 19:42
@Hellsice
Fixed ECOD and COPOD decision functions
942b921 
ECOD and COPOD decision functions were swapped.
The papers said COPOD was was the max of the three and ECOD used the aggregated left-tail and right-tail
code showed that COPOD used the aggregated left-tail and right-tail, and ECOD used the max of the three
@Hellsice
Fixed ECOD and COPOD decision functions
d5222c9 
ECOD and COPOD decision functions were swapped.
The papers said COPOD was was the max of the three and ECOD used the aggregated left-tail and right-tail
code showed that COPOD used the aggregated left-tail and right-tail, and ECOD used the max of the three
@Hellsice Hellsice changed the title Fixed COPOD and ECOD decision score inconsistency with their respective papers Fixed COPOD and ECOD decision function inconsistency with their respective papers May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Hellsice