Restore provenance in GlobalAlloc::{de,re}alloc when running on Miri#18
Merged
Restore provenance in GlobalAlloc::{de,re}alloc when running on Miri#18
GlobalAlloc::{de,re}alloc when running on Miri#18Conversation
yvt
force-pushed
the
test-global-restore-provenance
branch
5 times, most recently
from
e077376 to
a5fc573
Compare
yvt
force-pushed
the
test-global-restore-provenance
branch
from
a5fc573 to
0745b2a
Compare
…loc::dealloc` on Miri > In current Miri with Stacked Borrows aliasing model, global heap > allocations lose the provenance for the memory outside `layout`, > which prevents us from accessing their allocation metadata and > adjacent memory blocks. To work around this, we restore the original > provenance from the containing memory pool.
> A smaller value is used on Miri because it somehow speeds up > execution.
It runs successfully now that the pointer provenance issue with `GlobalAlloc::dealloc` has been addressed. It is too slow to run to completion, which I suspect is caused by triggering some pathological cases in Miri.
yvt
force-pushed
the
test-global-restore-provenance
branch
from
0745b2a to
344b03f
Compare
yvt
force-pushed
the
test-global-restore-provenance
branch
from
344b03f to
2f7c04f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work-around for rust-lang/miri#2104
FORCE_POOL_FTRis setiter_pools()indroptoo?