Fix menu loading with robust hook registration#20
Open
SwattyModding wants to merge 1 commit intoyumi-modding:mainfrom
Open
Fix menu loading with robust hook registration#20SwattyModding wants to merge 1 commit intoyumi-modding:mainfrom
SwattyModding wants to merge 1 commit intoyumi-modding:mainfrom
Conversation
Register the settings menu hook at source time instead of via a deferred init() call, preventing other mods from overwriting onFrameOpen during mission load. Add null checks for GUI elements and use dynamic element indices to avoid out-of-bounds errors. Bump version to 1.0.2.0. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
The latest version of FS25 made this menu diseappear from the Game Settings tab. This fixes it.
Summary
init()call, preventing other mods from overwritingonFrameOpenduring mission loadgameSettingsLayout,economicDifficulty, andcheckTrafficGUI elements to prevent crashesmath.min) instead of hardcoded values to avoid out-of-bounds errorsTest plan
🤖 Generated with Claude Code