Fix Chinese LanguageCode #516
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fied Chinese LanguageCode
Closed
iHad168
force-pushed
the
fix-chinese-languagecode
branch
from
7b437d6 to
bc17b94
Compare
Bnyro
force-pushed
the
fix-chinese-languagecode
branch
from
f6f2db2 to
bc17b94
Compare
Bnyro
reviewed
Jul 24, 2025
Member
Bnyro
left a comment
Bnyro
left a comment
There was a problem hiding this comment.
Couldn't we just take the first two letters of the language code everywhere instead of matching whether it's zh-Hant or zh-Hans?
I think we generally need to introduce a common format for all language codes used for simultaneous translation, that's not currently really well implemented.
Contributor
Author
|
I find this some engine is cannot know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Apertium DeepL Glosbe Lingva Mozhi MinT Yandex Traditional/Simplified Chinese LanguageCode