Skip to content

fix: rename storageKey to STORAGEKEY #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doctor-taco merged 1 commit into from
Feb 10, 2025
Merged

fix: rename storageKey to STORAGEKEY #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/pages/myPage/MyPage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { fetchIdols } from '@/apis/myPageApi.js';
import PrimaryButton from '@/components/PrimaryButton';
import xButton from '@/assets/icons/xButton.svg';

const storageKey = 'favoriteIdols';
const STORAGEKEY = 'favoriteIdols';

const MyPage = () => {
const [idols, setIdols] = useState([]);
Expand Down Expand Up @@ -39,7 +39,7 @@ const MyPage = () => {
}, []);

useEffect(() => {
const storedFavorites = localStorage.getItem(storageKey);
const storedFavorites = localStorage.getItem(STORAGEKEY);
if (storedFavorites) {
setFavoriteIdols(storedFavorites.split(',').map(Number));
}
Expand All @@ -58,7 +58,7 @@ const MyPage = () => {
if (selectedIdols.length === 0) return;
setFavoriteIdols((prev) => {
const updatedFavorites = [...new Set([...prev, ...selectedIdols])];
localStorage.setItem(storageKey, updatedFavorites.join(','));
localStorage.setItem(STORAGEKEY, updatedFavorites.join(','));
return updatedFavorites;
});
setSelectedIdols([]);
Expand All @@ -67,7 +67,7 @@ const MyPage = () => {
const handleRemoveFavorite = (idolId) => {
setFavoriteIdols((prev) => {
const updatedFavorites = prev.filter((id) => id !== idolId);
localStorage.setItem(storageKey, updatedFavorites.join(','));
localStorage.setItem(STORAGEKEY, updatedFavorites.join(','));
return updatedFavorites;
});
};
Expand Down