-
Notifications
You must be signed in to change notification settings - Fork 3
fix: #146/Fix MonthlyChartModal #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
juha399
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
지혜님 수고하셨습니다~!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modal component에서
const [isMobile, setIsMobile] = useState(window.innerWidth < 768);
로 수정하고 16번째에서 24번째 줄을 이렇게 바꾸는 것은 어떤가요???
useEffect(() => {
const handleResize = () => setIsMobile(window.innerWidth < 768);
window.addEventListener('resize', handleResize);
return () => window.removeEventListener('resize', handleResize);
}, []);
| <div className="fixed flex flex-col top-0 left-0 size-full bg-midnightBlack"> | ||
| // z-[9999] : 모달창이 열렸을 때 리스트 페이지에 있는 아이돌 이미지 보더가 같이 보이는 현상 해결을 위해 작성 | ||
| <div className="fixed flex flex-col top-0 left-0 size-full bg-midnightBlack z-[9999]"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기서 idolCard에 있는 border의 z인덱스를 지우는 것은 어떤가용 그게 필요가 없어 보이는 거 같아서요!
yoonc01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit 단위를 조금 더 세분화했으면 읽는데 더 편했을 거 같아요!
#️⃣ Issue Number
#146
📝 요약(Summary)
🛠️ PR 유형
어떤 변경 사항이 있나요?
📸스크린샷 (선택)
수정 부분이 너무 많아 사진으로 다 담기 어려울 거 같아 vercel에서 제공하는 PR 사이트 참고해 주시면 감사하겠습니다!! :)