Skip to content

Feat: #141/lighthouse 피드백 적용 #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doctor-taco merged 2 commits into from
Feb 7, 2025
Merged

Feat: #141/lighthouse 피드백 적용 #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc18907
feat: change png to webp and set width and height those cover the image
yoonc01 Feb 6, 2025
dfa164a
feat: Add preconnect to jsDelivr CDN for improved resource loading
yoonc01 Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<html lang="en">
<head>
<meta charset="UTF-8" />
<link rel="preconnect" href="https://cdn.jsdelivr.net" />
<link
rel="stylesheet"
href="https://cdn.jsdelivr.net/gh/orioncactus/pretendard/dist/web/static/pretendard.css"
Expand Down
Binary file added src/assets/images/leftTopGradient.webp
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/assets/images/mainSectionPhoneImage1.webp
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/assets/images/mainSectionPhoneImage2.webp
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/assets/images/mainSectionPhoneImage3.webp
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions src/pages/landingPage/IntroSection.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@ function IntroSection() {
<img
src={fandomKLogo}
alt="FandomKLogo"
className="cursor-pointer z-10 mt-[20px] w-[236px] tablet:w-[324px] pc:w-[512px] select-none"
className="cursor-pointer z-10 mt-[20px] w-[236px] h-[44px] tablet:w-[324px] tablet:h-[62px] pc:w-[512px] pc:h-[98px] select-none"
onClick={() => {
handleClick(false);
}}
/>
<img
src={idolImage}
alt="idolImage"
className="w-[392px] mt-[20px] h-auto opacity-70 top-[100px] tablet:w-[712px] pc:absolute pc:w-[932px] select-none"
className="w-[392px] h-[328px] mt-[20px] h-auto opacity-70 top-[100px] tablet:w-[712px] tablet:w-[596px] pc:absolute pc:w-[932px] pc:h-[780px] select-none"
/>
<PrimaryButton
className={
Expand Down
8 changes: 4 additions & 4 deletions src/pages/landingPage/LandingPage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import IntroSection from '@/pages/landingPage/IntroSection.jsx';
import leftTopGradient from '@/assets/images/leftTopGradient.png';
import phoneImage1 from '@/assets/images/mainSectionPhoneImage1.png';
import phoneImage2 from '@/assets/images/mainSectionPhoneImage2.png';
import phoneImage3 from '@/assets/images/mainSectionPhoneImage3.png';
import leftTopGradient from '@/assets/images/leftTopGradient.webp';
import phoneImage1 from '@/assets/images/mainSectionPhoneImage1.webp';
import phoneImage2 from '@/assets/images/mainSectionPhoneImage2.webp';
import phoneImage3 from '@/assets/images/mainSectionPhoneImage3.webp';
import MainSectionList from '@/pages/landingPage/MainSectionList';

const sections = [
Expand Down
2 changes: 1 addition & 1 deletion src/pages/landingPage/MainSectionList.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function MainSectionList({ headText, semiHeadText, imgData, backgroundImage }) {
<img
src={src}
alt={alt}
className="mt-[60px] w-[240px] tablet:w-[200px] pc:w-[320px]"
className="mt-[60px] w-[240px] h-[520px] tablet:w-[200px] tablet:h-[432px] pc:w-[320px] pc:h-[692px]"
/>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/pages/listPage/ListPage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import CreditRechargeSuccess from '@/components/modalContent/CreditRechargeSucce
import CreditShortageModalContent from '@/components/modalContent/CreditShortageModalContent';
import DonationsList from '@/pages/listPage/donation/DonationsList';
import DonationModalContent from '@/components/modalContent/DonationModalContent';
import leftTopGradient from '@/assets/images/leftTopGradient.png';
import leftTopGradient from '@/assets/images/leftTopGradient.webp';
import DonationSuccess from '@/components/modalContent/DonationSuccess';
import MonthlyChartSection from '@/pages/listPage/monthlyChart/MonthlyChartSection';

Expand Down