Fix/#28/favorite idol UI #126
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yoonc01
reviewed
Feb 4, 2025
Comment on lines
+12
to
+20
| server: { | ||
| proxy: { | ||
| '/api': { | ||
| target: 'https://fandom-k-api.vercel.app', | ||
| changeOrigin: true, | ||
| secure: false, | ||
| }, | ||
| }, | ||
| }, |
Collaborator
Author
There was a problem hiding this comment.
서버 오류시 프록시 사용을 권장한다고 하더라구요 굳이 필요 없나용
Comment on lines
+83
to
+84
| <div className="w-full min-h-screen bg-[#02000E] flex flex-col items-center "> | ||
| <Header /> |
Owner
There was a problem hiding this comment.
이거는 이전에 썼던 bg-midnightBlack 잘 쓰셨어요!
Comment on lines
+29
to
+30
| className="absolute overflow-hidden bg-white rounded-full | ||
| bg-transparent" |
Collaborator
Author
There was a problem hiding this comment.
중간에 하다가 올린거라 그래요 ㅋㅋ
Comment on lines
+21
to
+26
| if (typeof window !== 'undefined') { | ||
| if (window.innerWidth < 640) return 6; | ||
| if (window.innerWidth < 768) return 8; | ||
| return 16; | ||
| } | ||
| return 16; |
Owner
There was a problem hiding this comment.
결국 return 16을 할 거면
if (tyeof window !== 'undefined') 는 무의미한 거 같아요!
또 저희 반응형 크기는
https://github.com/yoonc01/Fandom-K/blob/main/tailwind.config.js#L25
이거에요!
Comment on lines
+37
to
+46
| useEffect(() => { | ||
| const storedFavorites = localStorage.getItem(storageKey); | ||
| if (storedFavorites) { | ||
| setFavoriteIdols(storedFavorites.split(',')); | ||
| } | ||
| }, []); | ||
|
|
||
| useEffect(() => { | ||
| localStorage.setItem(storageKey, favoriteIdols.join(',')); | ||
| }, [favoriteIdols]); |
Owner
There was a problem hiding this comment.
로컬스토리지 다루는 부분을 utils에 따로 설정할 수 있을 거 같아요!
또 로컬스토리지 다루는 부분에 대해서 재현님과 상의해서 매개변수로 storageKey를 받도록 해서 함수를 합칠 수도 있을 거 같아요!
Collaborator
Author
There was a problem hiding this comment.
어려워요 ㅋㅋ낼 팀미팅시간에 설명 한번만 부탁드려도 될까유//
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ Issue Number
📝 요약(Summary)
🛠️ PR 유형
어떤 변경 사항이 있나요?
📸스크린샷 (선택)
💬 공유사항
📚 코드 이해에 필요한(혹은 본인이 이해하는데 사용한) 레퍼런스 목록