Skip to content

Conversation

@mspirkov
Copy link
Contributor

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues

Found this bug using PHPStan.

image

Then I wrote tests, and they confirmed the error.

image

@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.49%. Comparing base (53bdfc3) to head (d10cecf).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #20530      +/-   ##
============================================
- Coverage     64.49%   64.49%   -0.01%     
+ Complexity    11574    11571       -3     
============================================
  Files           433      433              
  Lines         37606    37604       -2     
============================================
- Hits          24253    24251       -2     
  Misses        13353    13353              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mspirkov mspirkov marked this pull request as ready for review September 16, 2025 08:26
@samdark samdark merged commit 7143fdf into yiisoft:master Sep 16, 2025
96 checks passed
@samdark samdark added this to the 2.0.54 milestone Sep 16, 2025
@samdark
Copy link
Member

samdark commented Sep 16, 2025

Good catch and I like the early returns. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants