Fix #20273: Remove unnecessary paragonie/random_compat dependency
#20273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that Yii itself requires PHP 7.3 since 2.0.50, this dependency does nothing, as PHP 7.0+ guarantees the existence of the CSPRNG.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20273 +/- ##
=========================================
Coverage 64.84% 64.84%
Complexity 11399 11399
=========================================
Files 430 430
Lines 37137 37137
=========================================
Hits 24080 24080
Misses 13057 13057 ☔ View full report in Codecov by Sentry. |
samdark
approved these changes
Nov 4, 2024
samdark
changed the title
paragonie/random_compat dependencyparagonie/random_compat dependency
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that Yii itself requires PHP 7.3 since 2.0.50, this dependency does nothing, as PHP 7.0+ guarantees the existence of the CSPRNG.