Skip to content

Conversation

@terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Tests pass?

@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (13106d8) to head (0e07943).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #328   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        43        43           
===========================================
  Files             10        10           
  Lines            277       277           
===========================================
  Hits             277       277           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@terabytesoftw terabytesoftw marked this pull request as ready for review January 23, 2026 21:07
@terabytesoftw terabytesoftw requested a review from Copilot January 23, 2026 21:07
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the Docker configuration to prepare for PHP 8.5 compatibility and optimizes the development workflow. The changes modify the Docker setup, test configuration, CI/CD workflow, and documentation to streamline the development environment.

Changes:

  • Upgrades Docker image from PHP 8.2 to PHP 8.5 with a new image tag format
  • Adds named Docker volumes for runtime and assets directories with automatic permission management
  • Updates the GitHub Actions workflow to use composer install instead of composer update and runs all test suites instead of specific ones
  • Adjusts the acceptance test URL from localhost:8080 to localhost to match container-internal testing

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
docker-compose.yml Updates PHP version to 8.5, adds named volumes for runtime/assets, implements automatic permission setting via custom command
tests/Acceptance.suite.yml Changes test URL from localhost:8080 to localhost for container-internal test execution
.github/workflows/docker.yml Adds PHP_USER_ID environment variable, changes composer command from update to install, runs full test suite instead of specific suites
README.md Reorders badges (codecov before static analysis), adds documentation for running tests inside containers, removes logo parameter from Static Analysis badge

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@terabytesoftw terabytesoftw merged commit f7a6243 into master Jan 25, 2026
15 checks passed
@terabytesoftw terabytesoftw deleted the update-php85-docker-composer branch January 25, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants