-
-
Notifications
You must be signed in to change notification settings - Fork 789
Update Docker configuration to use PHP 8.5 and optimize Composer commands.
#328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
terabytesoftw
commented
Jan 23, 2026
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Tests pass? | ❌ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #328 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 43 43
===========================================
Files 10 10
Lines 277 277
===========================================
Hits 277 277 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request updates the Docker configuration to prepare for PHP 8.5 compatibility and optimizes the development workflow. The changes modify the Docker setup, test configuration, CI/CD workflow, and documentation to streamline the development environment.
Changes:
- Upgrades Docker image from PHP 8.2 to PHP 8.5 with a new image tag format
- Adds named Docker volumes for runtime and assets directories with automatic permission management
- Updates the GitHub Actions workflow to use
composer installinstead ofcomposer updateand runs all test suites instead of specific ones - Adjusts the acceptance test URL from
localhost:8080tolocalhostto match container-internal testing
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| docker-compose.yml | Updates PHP version to 8.5, adds named volumes for runtime/assets, implements automatic permission setting via custom command |
| tests/Acceptance.suite.yml | Changes test URL from localhost:8080 to localhost for container-internal test execution |
| .github/workflows/docker.yml | Adds PHP_USER_ID environment variable, changes composer command from update to install, runs full test suite instead of specific suites |
| README.md | Reorders badges (codecov before static analysis), adds documentation for running tests inside containers, removes logo parameter from Static Analysis badge |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.