Skip to content
This repository was archived by the owner on Apr 4, 2019. It is now read-only.

Added unique option #7

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Added unique option #7

wants to merge 5 commits into from

Conversation

teone
Copy link

@teone teone commented May 4, 2015

Hi @yields, I've added a unique options to create unique slug in you plugin.
It's tested, any comment is highly appreciated 😄

@martindale
Copy link
Collaborator

Can you please break out the style changes into a separate pull request?

@teone
Copy link
Author

teone commented May 5, 2015

Ok, no problem,
to be sure you mean the linter stuff and the TODO section in README.md?

@martindale
Copy link
Collaborator

Yep – this just doesn't need to be a 2,000+ file change with over 39,000 changed lines. Happy to accept that kind of change, but separately.

@teone
Copy link
Author

teone commented May 8, 2015

Hi I've founded a bug in updating unique slug (my fault!) fixed it and covered it with a test, for the refactor stuff I'm sorry but I don't have time to split in separate pull request... But as now the changes are not so many and your test are still passing, so hope it will not be to expensive for you to review them and eventually merge them...

@martindale
Copy link
Collaborator

Hey @teone, apologies for losing track of this. I'm adding it to my "to review" list and will get back to you on this soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants