Fixed Critical Security & Performance Issues #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated README to enhance project description, features, and installation instructions.
Added contact information
Update settings.py to load environment variables for sensitive data and improve security.
Refactor note handling and improve performance with prefetching.
Author
|
@ygowthamr please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Fixed #223 #224 #225
Security Vulnerabilities:
OAuth credentials exposure - Moved hardcoded GitHub credentials to environment variables
Input validation - Added tag filter validation to prevent unauthorised access
Performance Issues:
N+1 query problem
Database optimisation - Optimised shared note and permission lookups
📝 Documentation:
README overhaul - Professional documentation with setup instructions
Files Changed
[views.py] - Performance fixes & security enhancements
[settings.py] - Environment variable integration
[README.md] - Complete documentation rewrite
Setup Required
Create [.env] file:
GITHUB_CLIENT_ID=your_client_id
GITHUB_CLIENT_SECRET=your_client_secret
SECRET_KEY=your_secret_key
Ready for review!