Acessar servicos de assitencia#5
Merged
Merged
Conversation
…mbro da comissão)
Co-authored-by: Emmanuel N. C. Brito <code@yet1dev.com>
victorYghor
requested review from
Copilot and
yet1dev
and removed request for
yet1dev
There was a problem hiding this comment.
Pull Request Overview
This PR adds the “acessar serviços de assistência” flows by introducing a new feature file, extending step definitions, and updating services to handle wait-listing, service listing, and redirection based on PCD disability type.
- Introduces
acessarServicos.featurewith scenarios for listing services, directing to attendants, and handling queues. - Extends
StepDefinitions.ktwith new Cucumber steps to support service access, queue behavior, and cleanup. - Updates
WhatsappService,QueueService, andAttendanceServiceto support 24h message windows, first-in-first-out queue pop, and wait-list messaging.
Reviewed Changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/resources/.../registerPCD.feature | Updated step wording for service options |
| src/test/resources/.../acessarServicos.feature | New feature file for accessing assistance services |
| src/test/kotlin/.../StepDefinitions.kt | Added step defs for new scenarios and queue behavior |
| src/main/kotlin/.../WhatsappService.kt | Enhanced sendMessage with 24h check, logging, imports |
| src/main/kotlin/.../QueueService.kt | Added @Transactional to pop method |
| src/main/kotlin/.../ServiceType.kt | Added sorting and lookup helpers |
| src/main/kotlin/.../AttendanceService.kt | Merged status service, wait-list messaging |
| data/myDB.trace.db | Accidental database trace log checked in |
Comments suppressed due to low confidence (1)
src/main/kotlin/ufrpe/sbpc/botpcd/entity/ServiceType.kt:85
- The
getAlphabeticOrderimplementation usesreduceto combineCharandInt, which will not compile. You need an accumulator of typeIntand usefold(0) { acc, c -> acc + c.code }instead.
fun String.getAlphabeticOrder() = this.replace("[^a-zA-Z]".toRegex(), "").slice(0..9).reduce {prev, curr -> prev + curr.code}
| @@ -0,0 +1,38 @@ | |||
| 2025-05-20 12:36:33.423212Z jdbc[3]: exception | |||
There was a problem hiding this comment.
A database trace log file was checked in; consider removing it from source control or adding it to .gitignore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.