This repository was archived by the owner on Apr 20, 2018. It is now read-only.
Log home many files have been modified by usemin#493
Open
snasc wants to merge 1 commit intoyeoman:masterfrom
Open
Log home many files have been modified by usemin#493snasc wants to merge 1 commit intoyeoman:masterfrom
snasc wants to merge 1 commit intoyeoman:masterfrom
Conversation
tasks/usemin.js
Outdated
Collaborator
There was a problem hiding this comment.
@snasc I would say fileModified as you increment it in if (handler.isFileModified) {}
Collaborator
|
@snasc you should also squash your commits. |
Author
|
ok, I'll do it. |
Author
|
@stephanebachelier I've squashed it, and the variable is |
Collaborator
|
@snasc can you add a test ? |
stephanebachelier
changed the title
stephanebachelier
changed the title
Collaborator
|
ping @snasc Your PR is only about adding some log, - the number of files modified and not the list of file modified -, and (still) missing a test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a incremental deployment. But everty .html file will be transmit, even they acctually haven't been modified.
So I done this, the .html file haven't been changed will not be transmit.