Skip to content
This repository was archived by the owner on Apr 20, 2018. It is now read-only.

Ignore query string in dest and src when generate grunt config.#443

Open
ValorLin wants to merge 3 commits intoyeoman:masterfrom
ValorLin:master
Open

Ignore query string in dest and src when generate grunt config.#443
ValorLin wants to merge 3 commits intoyeoman:masterfrom
ValorLin:master

Conversation

@ValorLin
Copy link

fix: #439
And make this work.

<!-- build:css common.min.css?__inline=true -->
<link rel="stylesheet" href="foo.css"/>
<link rel="stylesheet" href="bar.css"/>
<!-- endbuild -->

<link rel="stylesheet" href="common.min.css?__inline=true"/>

@ValorLin ValorLin changed the title Remove query string in dest and src Ignore query string in dest and src when generate grunt config. Sep 28, 2014
@stephanebachelier
Copy link
Collaborator

@sindresorhus your thought about this ?

@sindresorhus
Copy link
Member

@stephanebachelier I don't have time or interest in reviewing things on this project, sorry. Feel free to merge PRs you think make sense.

@stephanebachelier
Copy link
Collaborator

@sindresorhus sorry I didn't see this comment before. Ignore my other comments :)

@sindresorhus
Copy link
Member

@stephanebachelier No worries. And I really appreciate you stepping in. I'm just burned out by this project.

@stephanebachelier
Copy link
Collaborator

@weilao I can see some use case where a query parameter might be needed.
Can you add a test

@ValorLin
Copy link
Author

@stephanebachelier
All done : )

@stephanebachelier
Copy link
Collaborator

ping @weilao
Could you squash and rebase on dev branch.
It might be easier to tweak the regexp to extract only the path instead of using an extra function.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add parameters to generated URL

3 participants