Skip to content

fix(Tenant): remove falsy query params from address #2690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2025
Merged

fix(Tenant): remove falsy query params from address #2690

merged 1 commit into from
Aug 8, 2025
+2 −2

Conversation

Raubzeug
Copy link
Contributor

@Raubzeug Raubzeug commented Aug 8, 2025 •
edited by github-actions bot
Loading

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
358 353 0 3 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 85.32 MB | Main: 85.32 MB
Diff: +0.05 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@Raubzeug Raubzeug enabled auto-merge August 8, 2025 13:26
@Raubzeug Raubzeug added this pull request to the merge queue Aug 8, 2025
Merged via the queue into main with commit 633b184 Aug 8, 2025
7 checks passed
@Raubzeug Raubzeug deleted the hide-bool-params branch August 8, 2025 15:11
@ydb-platform-bot ydb-platform-bot mentioned this pull request Aug 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemmufazalov artemmufazalov artemmufazalov approved these changes

@astandrik astandrik Awaiting requested review from astandrik astandrik is a code owner

@adameat adameat Awaiting requested review from adameat adameat is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Raubzeug @artemmufazalov