write proper /etc/selinux/config, according to expected format#162
Merged
Conversation
jreidinger
reviewed
Feb 5, 2026
| Thu Feb 5 13:18:03 UTC 2026 - Robert Frohl <rfrohl@suse.com> | ||
|
|
||
| - write proper /etc/selinux/config according to expected format | ||
| (bsc#1257752) |
Member
There was a problem hiding this comment.
please also bump version like other changes. This ensure that after merge it will be send to factory. ( change itself looks good )
Member
There was a problem hiding this comment.
so increase version in spec and add entry to changelog with mentioned number for easier tracking what is in which version.
Contributor
Author
There was a problem hiding this comment.
Please let me know if the change is sufficient or if more changes are needed.
Proper format should not carry additional spaces and should look like $ cat /etc/selinux/config SELINUX=disabled
jreidinger
approved these changes
Feb 6, 2026
Member
|
merged, thanks for patch |
|
❌ Autosubmission job #21749415738 failed |
Merged
|
❌ Autosubmission job #21749415738 failed |
Member
|
it should be finally auto submitted due to some issues with OBS: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proper format should not carry additional spaces and should look like
Problem
The config file format that is generated will not be parsed by the selinux toolchain
Solution
Removes unnecessary whitespaces.
Testing
Screenshots
If the fix affects the UI attach some screenshots here.