Skip to content

Fixes the pnpm linker crash on leftover workspace node_modules #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeckhart wants to merge 2 commits into
base: main
Choose a base branch
from
+44 −3
Open

Fixes the pnpm linker crash on leftover workspace node_modules #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9923fc9
Fixes the pnpm linker crash on leftover workspace node_modules
jeckhart May 30, 2026
d267886
Merge branch 'main' into fix/pnpm-linker-leftover-workspace-dirs
jeckhart Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/zpm/src/linker/pnpm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ pub async fn link_project_pnpm<'a>(project: &'a Project, install: &'a Install) -
.relative_to(&link_abs_dirname);

link_abs_path
.fs_rm_file()
.fs_rm()
.ok_missing()?
.unwrap_or(&link_abs_path)
.fs_create_parent()?
Expand Down Expand Up @@ -240,7 +240,7 @@ pub async fn link_project_pnpm<'a>(project: &'a Project, install: &'a Install) -
.relative_to(&link_abs_dirname);

link_abs_path
.fs_rm_file()
.fs_rm()
.ok_missing()?
.unwrap_or(&link_abs_path)
.fs_create_parent()?
Expand Down Expand Up @@ -304,7 +304,7 @@ pub async fn link_project_pnpm<'a>(project: &'a Project, install: &'a Install) -
.relative_to(&link_abs_dirname);

link_abs_path
.fs_rm_file()
.fs_rm()
.ok_missing()?
.unwrap_or(&link_abs_path)
.fs_create_parent()?
Expand Down
41 changes: 41 additions & 0 deletions tests/acceptance-tests/pkg-tests-specs/sources/features/pnpm.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,47 @@ describe(`Features`, () => {
),
);

test(
`it should replace leftover workspace node_modules directories when switching from the node-modules linker`,
makeTemporaryMonorepoEnv(
{
workspaces: [`packages/*`],
dependencies: {
[`no-deps`]: `1.0.0`,
},
},
{
[`packages/pkg-a`]: {
name: `pkg-a`,
version: `1.0.0`,
dependencies: {
[`no-deps`]: `2.0.0`,
},
},
},
async ({path, run}) => {
// Install with the node-modules linker first. The version conflict
// forces no-deps@2.0.0 to live as a real directory inside the
// workspace's own node_modules rather than being hoisted to the root.
await run(`config`, `set`, `nodeLinker`, `node-modules`);
await run(`install`);

const workspaceDep = npath.toPortablePath(`${path}/packages/pkg-a/node_modules/no-deps`);
const beforeStat = await xfs.lstatPromise(workspaceDep);
expect(beforeStat.isSymbolicLink()).toBeFalsy();
expect(beforeStat.isDirectory()).toBeTruthy();

// Switching to the pnpm linker must overwrite that leftover real
// directory with a symlink rather than failing to unlink it.
await run(`config`, `set`, `nodeLinker`, `pnpm`);
await run(`install`);

const afterStat = await xfs.lstatPromise(workspaceDep);
expect(afterStat.isSymbolicLink()).toBeTruthy();
},
),
);

test(
`pnpmHoistPatterns should hoist matching packages to store node_modules`,
makeTemporaryEnv(
Expand Down