feat(core): set proper User-Agent header on outgoing HTTP requests#7180
Open
blut-agent wants to merge 2 commits into
Open
feat(core): set proper User-Agent header on outgoing HTTP requests#7180blut-agent wants to merge 2 commits into
blut-agent wants to merge 2 commits into
Conversation
Set a meaningful User-Agent header on all outgoing HTTP requests, changing from the default 'got (https://github.com/sindresorhus/got)' to 'yarn/<version> node/<node_version>'. This allows sys admins to distinguish Yarn traffic and enforce package manager allow-lists across the organization, matching the convention already established by npm and pnpm. Closes yarnpkg#7146
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Set a meaningful
User-Agentheader on all outgoing HTTP requests, changing from the defaultgot (https://github.com/sindresorhus/got)toyarn/<version> node/<node_version>.Why
As a sys admin, I want package managers to identify themselves with a meaningful
User-Agentheader, but Yarn 4 currently sendsgot (https://github.com/sindresorhus/got)instead of identifying itself as Yarn. This makes it impossible to distinguish Yarn traffic and determine its exact version, preventing enforcement of package manager (and their versions) allow-lists across the organization.Changes
packages/yarnpkg-core/sources/httpUtils.ts: AddedgetDefaultUserAgent()andapplyDefaultHeaders()functions. Therequest()function now applies default headers before passing torequestImpl().packages/yarnpkg-core/tests/httpUtils.test.ts: Updated existing test to expect the User-Agent header, added test for default User-Agent, added test for preserving custom User-Agent headers.Test Plan
Closes #7146