feat: disable contentOnly update for unsynced patterns - #82
Merged
Conversation
YvetteNikolov
requested review from
Rovasch,
ShunLuk,
SimonvanWijhe,
dtakken,
ictbeheer,
mvdhoek1 and
rivanuff
July 7, 2026 09:12
YvetteNikolov
requested review from
a team,
FreakyWizard,
JasperS20,
WybeBosch,
Yannicvanveen and
laravdiemen
and removed request for
a team
July 7, 2026 09:13
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Gutenberg integration to opt out of WordPress 7.0’s default “content-only locking” behavior for unsynced patterns by injecting a corresponding editor setting via the block_editor_settings_all filter.
Changes:
- Add a new
block_editor_settings_allfilter handler to setdisableContentOnlyForUnsyncedPatternsin block editor settings. - Document why the behavior is being disabled (pending per-pattern control support in core).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+193
to
+195
| * We want this behavior, but it currently also locks creation patterns for non-page post types. | ||
| * Until core supports enabling/disabling this per pattern, we disable it globally. | ||
| * |
WybeBosch
approved these changes
Jul 7, 2026
WybeBosch
left a comment
WybeBosch
left a comment
Contributor
There was a problem hiding this comment.
wooho yeet de lock. WE SHALL NOT BE CHAINED!!!!!
mvdhoek1
reviewed
Jul 7, 2026
| #[Filter('block_editor_settings_all')] | ||
| public function disableContentOnlyForUnsyncedPatterns(array $settings): array | ||
| { | ||
| $settings['disableContentOnlyForUnsyncedPatterns'] = true; |
Contributor
There was a problem hiding this comment.
Geldt dit dan alleen voor nieuwe blokken of ook bestaande met bestaande instellingen?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Voor de frontenders