Skip to content

chore: remove duplicate security headers#64

Open
rivanuff wants to merge 1 commit into
mainfrom
chore/remove-dupe-sec-headers
Open

chore: remove duplicate security headers#64
rivanuff wants to merge 1 commit into
mainfrom
chore/remove-dupe-sec-headers

Conversation

@rivanuff

@rivanuff rivanuff commented Jun 3, 2026

Copy link
Copy Markdown

Copilot AI review requested due to automatic review settings June 3, 2026 08:46
@rivanuff
rivanuff requested a review from a team as a code owner June 3, 2026 08:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes several HTTP security headers from the PHP send_headers hook because they are already being set at the Nginx layer for (most) Brave sites, reducing the chance of duplicate response headers. It also corrects a method name typo related to the CSP header sender.

Changes:

  • Stop sending Strict-Transport-Security, X-Content-Type-Options, and X-Frame-Options from src/Security.php.
  • Keep Referrer-Policy and Permissions-Policy headers being sent from PHP.
  • Rename sendScpHeader() to sendCspHeader() for clarity/consistency.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants