chore: remove duplicate security headers#64
Open
rivanuff wants to merge 1 commit into
Open
Conversation
rivanuff
requested review from
Rovasch,
ShunLuk,
SimonvanWijhe,
dtakken,
ictbeheer and
mvdhoek1
June 3, 2026 08:46
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes several HTTP security headers from the PHP send_headers hook because they are already being set at the Nginx layer for (most) Brave sites, reducing the chance of duplicate response headers. It also corrects a method name typo related to the CSP header sender.
Changes:
- Stop sending
Strict-Transport-Security,X-Content-Type-Options, andX-Frame-Optionsfromsrc/Security.php. - Keep
Referrer-PolicyandPermissions-Policyheaders being sent from PHP. - Rename
sendScpHeader()tosendCspHeader()for clarity/consistency.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ShunLuk
approved these changes
Jun 3, 2026
mvdhoek1
approved these changes
Jun 3, 2026
ictbeheer
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deze headers worden voor vrijwel alle brave sites al gezet in: