feat: allow breadcrumbs to be filtered - #48
Merged
Conversation
rivanuff
requested review from
Rovasch,
ShunLuk,
SimonvanWijhe,
Copilot,
dtakken,
ictbeheer and
mvdhoek1
July 15, 2026 13:20
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a WordPress-style filter hook to allow consumers to modify the breadcrumb items collection before the component renders, enabling item removal/reordering/customization without overriding the component.
Changes:
- Introduces a
yard::brave-components/breadcrumb/itemsfilter to transform breadcrumb items before rendering. - Wraps the filtered result in an
Illuminate\Support\Collectionfor consistent downstream consumption.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mvdhoek1
previously approved these changes
Jul 15, 2026
| * | ||
| * @param Collection $items Crumbs shaped as ['id' => ?int, 'label' => string, 'url' => ?string]. | ||
| */ | ||
| $this->items = Collection::make(apply_filters('yard::brave-components/breadcrumb/items', $items)); |
There was a problem hiding this comment.
Wellicht nog mooi om dit toe te voegen aan readme?
- null-safe check on the items collection (Copilot) - document the breadcrumb items filter in the readme (@mvdhoek1)
ictbeheer
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.