feat/brave nav - #35
Merged
Merged
Conversation
…stead of a when it has children
YvetteNikolov
requested review from
FreakyWizard,
JasperS20,
Rovasch,
ShunLuk,
SimonvanWijhe,
WybeBosch,
Yannicvanveen,
dtakken,
ictbeheer,
laravdiemen,
mvdhoek1 and
rivanuff
April 14, 2026 11:31
|
Coverage report for commit: aba11da Summary - Lines: - | Methods: -
🤖 comment via lucassabreu/comment-coverage-clover |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Coverage report for commit: 7a091af Summary - Lines: - | Methods: -
🤖 comment via lucassabreu/comment-coverage-clover |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new “Nav” component set to the Brave components package, intended to support navigation markup with optional dropdowns and accompanying documentation.
Changes:
- Introduces a
Navcomponent class and a set of Blade subcomponents (nav,nav.list,nav.item,nav.link,nav.dropdown). - Implements basic markup/attribute merging for nav, list, item, link, and dropdown.
- Documents intended usage (with/without Navi) and dropdown “modes” in the README.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
src/Components/Nav.php |
Adds a class-based component wrapper for the nav view. |
resources/views/components/nav/index.blade.php |
Defines the root <nav> markup and required aria label prop. |
resources/views/components/nav/list.blade.php |
Adds a <ul> wrapper with default class merging. |
resources/views/components/nav/item.blade.php |
Adds a <li> wrapper with default class merging. |
resources/views/components/nav/link.blade.php |
Adds link/toggle rendering logic, active-state classes, and aria-current. |
resources/views/components/nav/dropdown.blade.php |
Adds dropdown <ul> markup with mode-based class and data-mode. |
README.md |
Documents the new Nav components and provides usage examples. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
twee ogen van wybe gekregen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.