Example #1
Open
Example #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a function that does the whole agent token + policy dance
more like a working version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for taking the time to look at my comments, much appreciated. I thought it was easier to chat about an example/diff!
I made a new function that does the agent token+policy generation so that can switch version approach based as needed.
I agree with you that providing a random file to source in isn't very high quality. I was trying to come up with a way that the end-user can say how they want this bit handled without the script having to have them all built in, but I think its going to be quite ugly in bash and so not really worth it.
I do think if the bootstrapping comes from separate files that get sourced in based on a storage parameter as here, then the functions don't have to know about the storage type and it ends up kinda like an interface that's easy to extend.
There are probably some import issues here, but its just an illustration