WIP - use voronoi-diagram-for-polygons for partition lines#874
Draft
usbalbin wants to merge 1 commit intoyaqwsx:masterfrom
Draft
WIP - use voronoi-diagram-for-polygons for partition lines#874usbalbin wants to merge 1 commit intoyaqwsx:masterfrom
usbalbin wants to merge 1 commit intoyaqwsx:masterfrom
Conversation
Author
|
Running this on a PCB with arcs in the outline or otherwise complex shapes seems to produce a partition line consisting of loads of little segments. This does seem to have quite bad affect on the performance. In one of my tests on one such PCB the panelization took about 200 seconds. Without the normal BB partitioning it would have taken about 10 or so seconds |
Owner
|
Thank you for your efforts! The partition line you propose is suitable for tabs placement; however, it is unsuitable for backbones. I started implementing a solution in d7622a1, however, making it roboust is quite challenging. So we either need to finish the robust solution or make the partition line engine switchable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kikit panelize \ --layout 'alternation: cols; vevendiff: 0mm; rotation: 90deg; rows: 2; cols: 2; baketext: False; hspace: -10mm; vspace: 10mm' \ --tabs 'type: fixed' \ --cuts 'type: mousebites' \ --framing 'type: tightframe; hspace: 2mm; vspace: 2mm; width: 10mm' \ l.kicad_pcb 'out.kicad_pcb' --debug 'drawPartitionLines: true' && pcbnew 'out.kicad_pcbThis is a of some sort of proof of concept state at this point. I am not too familiar with kikit's internals but as far as I can tell the partition lines does seem to make some sense, right?
I think I might me missing something since the tabs on the left and right towards the panel are missing