Allow to specify layer for annotation source#846
Open
cyberhuman wants to merge 1 commit intoyaqwsx:masterfrom
Open
Allow to specify layer for annotation source#846cyberhuman wants to merge 1 commit intoyaqwsx:masterfrom
cyberhuman wants to merge 1 commit intoyaqwsx:masterfrom
Conversation
set-soft
added a commit
to INTI-CMNB/KiBot
that referenced
this pull request
Aug 14, 2025
- Defaults to Edge.Cuts See yaqwsx/KiKit#846
Contributor
Author
|
@yaqwsx any feedback? I've been using this for a while and find it quite convenient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When source consists of several isolated pieces, currently the way to select them is via the bounding box selection (the "rectangle" option). However it means the coordinates of the bounding box must be provided. This PR makes it possible to have a bounding box rectangle drawn on a user layer, and an annotation footprint pointing to that rectangle, to define the bounding box coordinates.
It also makes it possible to modify a single-piece source boundary without worrying the annotation doesn't point at its edge anymore.