docs: Document the Spider-based compression orchestration in the deployment orchestration dev doc. - #2455
Draft
LinZhihao-723 wants to merge 5 commits into
Draft
docs: Document the Spider-based compression orchestration in the deployment orchestration dev doc.#2455LinZhihao-723 wants to merge 5 commits into
LinZhihao-723 wants to merge 5 commits into
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR depends on #2441.
The deployment orchestration dev doc still describes CLP as a purely Celery-based deployment. It doesn't mention Spider or
compression-coordinator, and its "Deployment types" section only covers the query engine, so there's no documented picture of how compression jobs are orchestrated once Spider is enabled.This PR brings the doc up to date with the Spider-based compression path:
Architecture (Figure 1 and Table 1)
spider-serviceandcompression-coordinatorto the architecture diagram, under newSpiderandCoordinatorssubgraphs.compression-coordinator's dependencies:db-table-creatorcompleting successfully.spider-servicebeing healthy.linkStyleindices, and gives the new Spider dependency its own edge colour so it remains visually distinct from the existing edge categories.spider_serviceandcompression_coordinatorrows to Table 1.Deployment types
compression-coordinator, which routes compression jobs to be driven by Spider. This is orthogonal to the query engine: queries continue to be driven by Celery or Presto according to the deployment type.compression-schedulerremains enabled by default, sincecompression-coordinatorcan currently only coordinate compression jobs created bylog-ingestor. It will be deprecated in a future release once Spider fully replaces it.Checklist
breaking change.
Validation performed