Skip to content

ci: Make the container image registry configurable. - #2450

Open
jackluo923 wants to merge 2 commits into
ci-localstack-local-runner-fixfrom
ci-configurable-registry
Open

ci: Make the container image registry configurable.#2450
jackluo923 wants to merge 2 commits into
ci-localstack-local-runner-fixfrom
ci-configurable-registry

Conversation

@jackluo923

@jackluo923 jackluo923 commented Aug 2, 2026

Copy link
Copy Markdown
Member

Description

Makes the container image registry host and credentials configurable via a workflow-level env block backed by repo variable REGISTRY and secrets REGISTRY_USERNAME / REGISTRY_PASSWORD, defaulting to ghcr.io + ${{github.actor}} + ${{secrets.GITHUB_TOKEN}}. clp-core-build-containers and run-on-image gain image_registry* inputs mirroring clp-build-runtime-image. run-on-image only logs in when a registry username is configured, so OSS keeps pulling published images anonymously from public ghcr.io — behavior is unchanged when the variable and secrets are unset.

Checklist

Validation performed

  • yamllint clean on the three changed files; actionlint reports no new findings (only the pre-existing SC2046 chown warnings repo-wide).
  • All CI checks on the branch pass (to be confirmed once the run completes).

Parameterize the container image registry host and credentials through a workflow-level env block (IMAGE_REGISTRY / IMAGE_REGISTRY_USERNAME / IMAGE_REGISTRY_PASSWORD) backed by repo variable GH_IMAGE_REGISTRY and secrets GH_IMAGE_REGISTRY_USERNAME / GH_IMAGE_REGISTRY_PASSWORD, defaulting to ghcr.io + github.actor + GITHUB_TOKEN so upstream and forks are byte-identical when unset. clp-core-build-containers and run-on-image gain image_registry* inputs mirroring clp-build-runtime-image. run-on-image only logs in when a registry username is configured (the secrets are passed without an actor fallback), preserving OSS's anonymous public pull of published images.
@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 5b3af4ee-47f5-4912-a8e0-434ce5c81583

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Renames the configurable-registry repo variable and secrets from GH_IMAGE_REGISTRY / GH_IMAGE_REGISTRY_USERNAME / GH_IMAGE_REGISTRY_PASSWORD to the shorter REGISTRY / REGISTRY_USERNAME / REGISTRY_PASSWORD. Only the vars/secrets references in clp-artifact-build.yaml change; the workflow env vars (IMAGE_REGISTRY*) and the action inputs (image_registry*) are unchanged.
@jackluo923
jackluo923 marked this pull request as ready for review August 2, 2026 23:18
@jackluo923
jackluo923 requested a review from a team as a code owner August 2, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant