ci: Make the container image registry configurable. - #2450
Open
jackluo923 wants to merge 2 commits into
Open
Conversation
Parameterize the container image registry host and credentials through a workflow-level env block (IMAGE_REGISTRY / IMAGE_REGISTRY_USERNAME / IMAGE_REGISTRY_PASSWORD) backed by repo variable GH_IMAGE_REGISTRY and secrets GH_IMAGE_REGISTRY_USERNAME / GH_IMAGE_REGISTRY_PASSWORD, defaulting to ghcr.io + github.actor + GITHUB_TOKEN so upstream and forks are byte-identical when unset. clp-core-build-containers and run-on-image gain image_registry* inputs mirroring clp-build-runtime-image. run-on-image only logs in when a registry username is configured (the secrets are passed without an actor fallback), preserving OSS's anonymous public pull of published images.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Renames the configurable-registry repo variable and secrets from GH_IMAGE_REGISTRY / GH_IMAGE_REGISTRY_USERNAME / GH_IMAGE_REGISTRY_PASSWORD to the shorter REGISTRY / REGISTRY_USERNAME / REGISTRY_PASSWORD. Only the vars/secrets references in clp-artifact-build.yaml change; the workflow env vars (IMAGE_REGISTRY*) and the action inputs (image_registry*) are unchanged.
jackluo923
marked this pull request as ready for review
August 2, 2026 23:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes the container image registry host and credentials configurable via a workflow-level
envblock backed by repo variableREGISTRYand secretsREGISTRY_USERNAME/REGISTRY_PASSWORD, defaulting toghcr.io+${{github.actor}}+${{secrets.GITHUB_TOKEN}}.clp-core-build-containersandrun-on-imagegainimage_registry*inputs mirroringclp-build-runtime-image.run-on-imageonly logs in when a registry username is configured, so OSS keeps pulling published images anonymously from public ghcr.io — behavior is unchanged when the variable and secrets are unset.Checklist
Validation performed
SC2046chown warnings repo-wide).