Skip to content

cached-fetch - Feature: Self-expiring memory store #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cached-fetch - Feature: Self-expiring memory store #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions cached-fetch/src/stores/createSelfExpiringMemoryStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
import { Store } from "../types";

import { createMemoryStore } from "./createMemoryStore";

const DEFAULT_TTL = 1000;

type Milliseconds = number;

interface Options {
ttl?: Milliseconds;
}

export function createSelfExpiringMemoryStore<T>(options: Options = {}): Store<T> {
const store = createMemoryStore<T>()
const timers = new Map<string, ReturnType<typeof setTimeout>>()
const { ttl = DEFAULT_TTL } = options

return {
has(key) {
return store.has(key)
},
get(key) {
return store.get(key)
},
set(key, value, date?) {
clearTimeout(timers.get(key))
timers.set(
key,
setTimeout(() => store.del(key), ttl),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
setTimeout(() => store.del(key), ttl),
setTimeout(() => { store.del(key); clearTimeout(timers.get(key)) }, ttl),

i think we need to remove the ref of the timer in the timeout otherwise the happy path would keep the timer ref forever. no?

)
return store.set(key, value, date)
},
del(key) {
clearTimeout(timers.get(key))
return store.del(key)
},
clear() {
timers.forEach((timeout) => clearTimeout(timeout))
return store.clear()
},
};
}
1 change: 1 addition & 0 deletions cached-fetch/src/stores/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
export * from './createMemoryStore'
export * from './createSelfExpiringMemoryStore'