Add the possibility to define a task description template #94 #238
Conversation
* Update Task livetable to have the same filter excluding 'Template' pages as Kanban, Task Dependencies and Gantt
* Added TaskTemplateList page * Changed how title works for Template tasks
* Added Create Template button * Formatting * Exclude templates from task panel
* Move TaskManagerTemplate to Template space * Formatting
* Added task template section to admin section
* Fix TaskTemplateProvider Template
|
It doesnt seem to actually change the task manager class |
|
It used to change a query on a custom displayer for dependencies in the TaskManagerClass. Now that the displayers were moved to separate pages, it doesn't affect the class anymore |
trrenty
left a comment
trrenty
left a comment
There was a problem hiding this comment.
Looks good. I didn't see you prepared the PR for merge
application-task-ui/src/main/resources/TaskManager/TaskManagerTemplates/TaskManagerTemplate.xml
Outdated
Show resolved
Hide resolved
| ] | ||
| }); | ||
| require(['jquery', 'xwiki-l10n!xwiki-task-template-list-notification-messages'], function ($, l10n) { | ||
| var escapeHTML = function(text) { |
There was a problem hiding this comment.
I dont think you need to escape the text for html, do you? I've never seen anyone doing it in the platform, for example
There was a problem hiding this comment.
Without the html escape, a <script> tag inside the translation gets executed. Maybe an alternative would be to use sanitize.js.
trrenty
left a comment
trrenty
left a comment
There was a problem hiding this comment.
On second thought, some tests would be nice so we know this feature works
|
While testing, I found that newer versions of XWiki (like 16.10.13) give an error when creating a template. |
* Add tests * Fix templates on XWiki >14.10
* Re-export TaskManagerTemplate * Fix some merge conflict * Change template check in the sheet
...cation-task-default/src/main/java/com/xwiki/task/internal/TaskObjectUpdateEventListener.java
Outdated
Show resolved
Hide resolved
...sk-test/application-task-test-docker/src/test/it/com/xwiki/task/test/ui/TaskTemplatesIT.java
Outdated
Show resolved
Hide resolved
...sk-test/application-task-test-docker/src/test/it/com/xwiki/task/test/ui/TaskTemplatesIT.java
Outdated
Show resolved
Hide resolved
...eobjects/src/main/java/org/xwiki/contrib/application/task/test/po/TaskManagerInlinePage.java
Show resolved
Hide resolved
2 participants
This PR changes theTaskManagerClasspage, so it will take a long time to upgrade.(Reopened from #214 )