Warn or straight up refuse to migrate spaces that would overwrite well known spaces #320 #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphj
reviewed
Nov 19, 2025
...-pro-default/src/main/java/com/xwiki/confluencepro/internal/ConfluenceFilteringListener.java
Outdated
Show resolved
Hide resolved
raphj
requested changes
Nov 27, 2025
...-confluence-migrator-pro-ui/src/main/resources/ConfluenceMigratorPro/Code/MigrationSheet.xml
Outdated
Show resolved
Hide resolved
...nce-migrator-pro-api/src/main/java/com/xwiki/confluencepro/ConfluenceMigrationJobStatus.java
Outdated
Show resolved
Hide resolved
...-pro-default/src/main/java/com/xwiki/confluencepro/internal/ConfluenceFilteringListener.java
Outdated
Show resolved
Hide resolved
...-confluence-migrator-pro-ui/src/main/resources/ConfluenceMigratorPro/Code/MigrationSheet.xml
Outdated
Show resolved
Hide resolved
pom.xml
Outdated
| <listeneradmin.version>1.0.2</listeneradmin.version> | ||
| <xwiki.extension.category>application</xwiki.extension.category> | ||
| <confluence.version>9.88.4</confluence.version> | ||
| <confluence.version>9.88.105-SNAPSHOT</confluence.version> |
Contributor
There was a problem hiding this comment.
This should not be merged.
On the other hand, if it gets merged, it's not the end of the world because I'm soon releasing Confluence Migrator Pro with an updated confluence.version, so this has no chance of ending up in a release.
raphj
approved these changes
Nov 27, 2025
raphj
reviewed
Nov 28, 2025
pom.xml
Outdated
| <groupId>com.xwiki.confluencepro</groupId> | ||
| <artifactId>application-confluence-migrator-pro</artifactId> | ||
| <version>1.36.0-rc-2-SNAPSHOT</version> | ||
| <version>9.88.4</version> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because this changes depends on other changes related to confluence-xml, included in xwiki-contrib/confluence#78 , once the PR is merged and a release is made, the dependency on org.xwiki.contrib.confluence:confluence-xml should be updated to include the new code before this PR is merged!