Cross-compile binaries for aarch64-unknown-linux-gnu #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malor
commented
Nov 24, 2024
| cross_compile_os: linux | ||
| cross_compile_target: aarch64-unknown-linux-gnu | ||
| - name: ubuntu-latest | ||
| cross_compile_os: |
There was a problem hiding this comment.
Not sure if we need to specify those... If we don't, surely ${{ }} expressions referencing those fields will fail?
There was a problem hiding this comment.
Yeah, I don't think we need to specify this. Can't say for sure though.
malor
commented
Nov 24, 2024
| source rustc.vars | ||
| if [ -z "${CROSS_COMPILE_TARGET}" ]; then | ||
| # normal build targetting the CPU architecture and the OS of the host | ||
| rustc --print cfg | grep = > rustc.vars |
There was a problem hiding this comment.
Alternatively, we can get rid of calling rustc to set target_os and target_arch, and specify the values for both statically in the config.
GitHub does not provide a aarch64-unknown-linux-gnu runner that we would need to compile binaries for Raspberry Pi, but we can use `cross` to build those on the amd64 Ubuntu runner.
ikalnytskyi
approved these changes
Nov 24, 2024
| cross_compile_os: linux | ||
| cross_compile_target: aarch64-unknown-linux-gnu | ||
| - name: ubuntu-latest | ||
| cross_compile_os: |
There was a problem hiding this comment.
Yeah, I don't think we need to specify this. Can't say for sure though.
|
|
||
| runs-on: ${{ matrix.os }} | ||
| - name: ubuntu-latest | ||
| cross_compile_os: linux |
There was a problem hiding this comment.
can we somehow infer this from matrix.os? maybe using uname or something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub does not provide a aarch64-unknown-linux-gnu runner that we would need to compile binaries for Raspberry Pi, but we can use
crossto build those on the amd64 Ubuntu runner.