Skip to content

Fix testnet-staging deployment#320

Merged
fbac merged 2 commits intomainfrom
fbac/fix-staging
Apr 23, 2026
Merged

Fix testnet-staging deployment#320
fbac merged 2 commits intomainfrom
fbac/fix-staging

Conversation

@fbac
Copy link
Copy Markdown
Collaborator

@fbac fbac commented Apr 23, 2026

Update testnet-staging contract addresses for DistributionManager and PayerReportManager

Updates config/testnet-staging.json and environments/testnet-staging.json with new proxy and implementation addresses for DistributionManager and PayerReportManager, bumping proxy salts from _1_1 to _1_2.

Macroscope summarized 1f6d6ac.

@fbac fbac requested a review from a team as a code owner April 23, 2026 12:39
@macroscopeapp
Copy link
Copy Markdown

macroscopeapp Bot commented Apr 23, 2026

Approvability

Verdict: Approved

Configuration-only changes updating smart contract deployment addresses for testnet-staging environment. The author owns both modified files, and the changes are limited to address values pointing to redeployed contracts on a staging network.

You can customize Macroscope's approvability policy. Learn more.

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Apr 23, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

Changes to gas cost

Generated at commit: 2b5274c4b75e5d34d61abcdf69db5147ad4e0549, compared to commit: 5e57ec40bb15d360e65236715add4ae01615fba3

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %
GenericEIP1967Migrator fallback -800 ✅ -19.37%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
GenericEIP1967Migrator 121,763 (0) fallback 1,330 (-2,800) -67.80% 3,330 (-800) -19.37% 4,130 (0) 0.00% 4,130 (0) 0.00% 7 (0)
Proxy 105,099 (0) fallback 4,971 (0) 0.00% 563,724 (-64) -0.01% 31,981 (0) 0.00% 2,861,555,004 (0) 0.00% 16,103 (+2)
SettlementChainGatewayUpgrader 7,779,797 (+12)
MockProxy 128,311 (-12)
FeeTokenHarness 2,155,175 (+12)
GroupMessageBroadcasterHarness 1,576,569 (-12)
RateRegistryHarness 1,287,888 (+12)
RegistryParametersHarness 835,192 (+12)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

LCOV of commit 1f6d6ac during Solidity #786

Summary coverage rate:
  lines......: 99.9% (1366 of 1367 lines)
  functions..: 100.0% (387 of 387 functions)
  branches...: no data found

Files changed coverage rate: n/a

@macroscopeapp macroscopeapp Bot dismissed their stale review April 23, 2026 13:05

Dismissing prior approval to re-evaluate 1f6d6ac

@fbac fbac merged commit 1343f50 into main Apr 23, 2026
14 checks passed
@fbac fbac deleted the fbac/fix-staging branch April 23, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant