Skip to content

Upgrade mainnet addresses#319

Merged
fbac merged 3 commits intomainfrom
fbac/upgrade-mainnet
Apr 15, 2026
Merged

Upgrade mainnet addresses#319
fbac merged 3 commits intomainfrom
fbac/upgrade-mainnet

Conversation

@fbac
Copy link
Copy Markdown
Collaborator

@fbac fbac commented Apr 14, 2026

Upgrade mainnet addresses and add FireblocksNote.generateNote helper

  • Updates several addresses in mainnet.json, including distributionManagerImplementation, payerReportManagerImplementation, and settlement chain admin accounts.
  • Adds FireblocksNote.generateNote in FireblocksNote.sol, a pure helper that constructs a note from provided parameters without consulting environment variables.
  • Updates BaseAppChainUpgrader and BaseSettlementChainUpgrader to use FireblocksNote.generateNote directly when logging FIREBLOCKS_NOTE_FOR_STEP_2, replacing the previous _getFireblocksNote call.

Macroscope summarized f5f68ac.

@fbac fbac requested a review from a team as a code owner April 14, 2026 19:39
@macroscopeapp
Copy link
Copy Markdown

macroscopeapp Bot commented Apr 14, 2026

Approvability

Verdict: Needs human review

This PR updates mainnet production addresses (implementation contracts and admin addresses) which constitutes a significant production infrastructure change. While the script refactoring is minor and the author owns all changed files, mainnet address changes warrant human verification to ensure the new addresses are correct and intentional.

You can customize Macroscope's approvability policy. Learn more.

@github-actions
Copy link
Copy Markdown

Changes to gas cost

Generated at commit: cd17f5db3a661bc6a75eb98d9d8b2a121826770a, compared to commit: 18152b8fd705c2dada0edb07f048728717df52d8

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %
Proxy __setPauseStatus
fallback
initialize()
initialize(address[])
+7,941 ❌
+147,544,636 ❌
+1,584 ❌
+26,062 ❌
+32.73%
+25772.89%
+2.50%
+29.15%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
Proxy 105,099 (0) __getRegistryParameter
__getUnderlyingFeeToken
__mint
__setMaxPayloadSize
__setMinPayloadSize
__setPauseStatus
__setPayloadBootstrapper
__setSequenceId
adminParameterKey
contractName
fallback
feeToken
implementation
initialize()
initialize(address[])
maxPayloadSize
migrate
migratorParameterKey
minPayloadSizeParameterKey
name
parameterRegistry
paused
pausedParameterKey
symbol
updatePauseStatus
version
7,886 (-26)
5,079 (-12)
56,427 (0)
821 (0)
804 (0)
826 (0)
48,465 (-228)
7,332 (0)
5,264 (-21)
5,264 (-1)
5,005 (+34)
5,061 (-9)
5,100 (0)
28,489 (-1)
29,075 (0)
7,140 (0)
28,601 (-740)
5,242 (-44)
5,308 (0)
7,987 (-62)
5,005 (-23)
7,148 (0)
5,285 (-67)
7,999 (-45)
29,288 (-33)
5,231 (-45)
-0.33%
-0.24%
0.00%
0.00%
0.00%
0.00%
-0.47%
0.00%
-0.40%
-0.02%
+0.68%
-0.18%
0.00%
-0.00%
0.00%
0.00%
-2.52%
-0.83%
0.00%
-0.77%
-0.46%
0.00%
-1.25%
-0.56%
-0.11%
-0.85%
7,910 (-2)
5,085 (-6)
63,294 (+1,284)
18,537 (+8,046)
15,867 (+4,642)
32,201 (+7,941)
48,617 (-76)
25,171 (+280)
5,285 (-12)
5,294 (+3)
148,117,116 (+147,544,636)
5,067 (-3)
5,144 (-7)
64,959 (+1,584)
115,466 (+26,062)
7,176 (+14)
32,684 (-102)
5,308 (-9)
5,315 (+7)
8,018 (-31)
5,035 (-4)
7,166 (+1)
5,331 (-21)
8,021 (-23)
35,197 (+14)
5,286 (-9)
-0.03%
-0.12%
+2.07%
+76.69%
+41.35%
+32.73%
-0.16%
+1.12%
-0.23%
+0.06%
+25772.89%
-0.06%
-0.14%
+2.50%
+29.15%
+0.20%
-0.31%
-0.17%
+0.13%
-0.39%
-0.08%
+0.01%
-0.39%
-0.29%
+0.04%
-0.17%
7,912 (0)
5,085 (-6)
56,439 (0)
821 (0)
804 (0)
48,430 (+19,912)
48,693 (0)
27,232 (0)
5,285 (-12)
5,287 (0)
48,852 (+16,931)
5,070 (0)
5,145 (-22)
50,056 (0)
124,407 (+9)
7,185 (+23)
33,581 (-44)
5,311 (-19)
5,308 (0)
8,018 (-31)
5,028 (0)
7,169 (+21)
5,335 (-17)
8,021 (-23)
31,503 (0)
5,281 (-6)
0.00%
-0.12%
0.00%
0.00%
0.00%
+69.82%
0.00%
0.00%
-0.23%
0.00%
+53.04%
0.00%
-0.43%
0.00%
+0.01%
+0.32%
-0.13%
-0.36%
0.00%
-0.39%
0.00%
+0.29%
-0.32%
-0.29%
0.00%
-0.11%
7,934 (+22)
5,091 (0)
73,527 (0)
48,425 (0)
48,408 (0)
48,525 (+30)
48,693 (0)
31,336 (0)
5,309 (0)
5,336 (+6)
2,861,555,004 (0)
5,070 (0)
5,179 (0)
145,712 (+49,979)
124,407 (+9)
7,185 (0)
37,542 (0)
5,378 (+47)
5,330 (+22)
8,049 (0)
5,061 (0)
7,202 (0)
5,352 (0)
8,044 (0)
52,806 (+60)
5,331 (0)
+0.28%
0.00%
0.00%
0.00%
0.00%
+0.06%
0.00%
0.00%
0.00%
+0.11%
0.00%
0.00%
0.00%
+52.21%
+0.01%
0.00%
0.00%
+0.88%
+0.41%
0.00%
0.00%
0.00%
0.00%
0.00%
+0.11%
0.00%
12 (+10)
2 (+1)
52 (+6)
33 (+7)
29 (+5)
61 (+20)
9 (+3)
23 (+1)
4 (+2)
14 (+9)
58 (-15,783)
6 (+4)
15 (+10)
545 (+363)
32 (+25)
5 (+3)
50 (+40)
14 (+9)
3 (+1)
2 (+1)
20 (+14)
17 (+12)
7 (+4)
2 (+1)
25 (+20)
14 (+9)
DistributionManagerUpgrader 8,192,519 (+35,463)
FeeTokenUpgrader 7,556,995 (+37,633)
PayerRegistryUpgrader 8,759,154 (+37,651)
PayerReportManagerUpgrader 8,780,778 (+34,181)
RateRegistryUpgrader 6,142,897 (+35,493)
SettlementChainGatewayUpgrader 7,779,785 (+35,498)
SettlementChainParameterRegistryUpgrader 5,840,431 (+34,172)
MockMigrator 96,913 (-12)

@github-actions
Copy link
Copy Markdown

LCOV of commit f5f68ac during Solidity #783

Summary coverage rate:
  lines......: 99.9% (1366 of 1367 lines)
  functions..: 100.0% (387 of 387 functions)
  branches...: no data found

Files changed coverage rate: n/a

@fbac fbac merged commit 5e57ec4 into main Apr 15, 2026
15 checks passed
@fbac fbac deleted the fbac/upgrade-mainnet branch April 15, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants