Conversation
ApprovabilityVerdict: Needs human review This PR updates mainnet production addresses (implementation contracts and admin addresses) which constitutes a significant production infrastructure change. While the script refactoring is minor and the author owns all changed files, mainnet address changes warrant human verification to ensure the new addresses are correct and intentional. You can customize Macroscope's approvability policy. Learn more. |
Changes to gas cost
🧾 Summary (20% most significant diffs)
Full diff report 👇
|
LCOV of commit
|
neekolas
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade mainnet addresses and add
FireblocksNote.generateNotehelperdistributionManagerImplementation,payerReportManagerImplementation, and settlement chain admin accounts.FireblocksNote.generateNotein FireblocksNote.sol, a pure helper that constructs a note from provided parameters without consulting environment variables.BaseAppChainUpgraderandBaseSettlementChainUpgraderto useFireblocksNote.generateNotedirectly when loggingFIREBLOCKS_NOTE_FOR_STEP_2, replacing the previous_getFireblocksNotecall.Macroscope summarized f5f68ac.