Merged
Conversation
Changes to gas cost
🧾 Summary (20% most significant diffs)
Full diff report 👇
|
ApprovabilityVerdict: Needs human review 1 blocking correctness issue found. Updates testnet factory addresses and simplifies the deployment script from CREATE2-based deployment to direct CREATE. While the changes are testnet-only configuration and script simplification, there's an unresolved documentation comment about an incorrect example that should be addressed before merging. You can customize Macroscope's approvability policy. Learn more. |
LCOV of commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploy upgradeable Factories via direct CREATE and update testnet config addresses
DeployFactory.s.solto deploy Factory implementation and proxy viaFactoryDeployer(direct CREATE) instead of routing through an old Factory using CREATE2 with a salt.predictAddresses(), salt-based error types, and old-factory dependencies; adds_readFactoryFromEnvironment()to resolve the correct factory address per chain fromenvironments/<env>.json.verifyDeployment()now reads the factory address from environments JSON rather than comparing against predicted addresses.factoryandfactoryImplementationaddresses inconfig/testnet-dev.json,config/testnet-staging.json, andconfig/testnet.json, andsettlementChainFactoryin the correspondingenvironments/files.DeployFactory.s.solno longer exposespredictAddresses()and deployment no longer requiresfactoryProxySaltor an existing old Factory contract.Macroscope summarized 7666914.