Skip to content

Deploy new upgradeable Factories#318

Merged
fbac merged 3 commits intomainfrom
fbac/deploy-upgradable-factories
Apr 13, 2026
Merged

Deploy new upgradeable Factories#318
fbac merged 3 commits intomainfrom
fbac/deploy-upgradable-factories

Conversation

@fbac
Copy link
Copy Markdown
Collaborator

@fbac fbac commented Apr 13, 2026

Deploy upgradeable Factories via direct CREATE and update testnet config addresses

  • Rewrites DeployFactory.s.sol to deploy Factory implementation and proxy via FactoryDeployer (direct CREATE) instead of routing through an old Factory using CREATE2 with a salt.
  • Removes predictAddresses(), salt-based error types, and old-factory dependencies; adds _readFactoryFromEnvironment() to resolve the correct factory address per chain from environments/<env>.json.
  • verifyDeployment() now reads the factory address from environments JSON rather than comparing against predicted addresses.
  • Updates factory and factoryImplementation addresses in config/testnet-dev.json, config/testnet-staging.json, and config/testnet.json, and settlementChainFactory in the corresponding environments/ files.
  • Behavioral Change: DeployFactory.s.sol no longer exposes predictAddresses() and deployment no longer requires factoryProxySalt or an existing old Factory contract.

Macroscope summarized 7666914.

@fbac fbac requested a review from a team as a code owner April 13, 2026 11:04
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 13, 2026

Changes to gas cost

Generated at commit: 3099b39ddbda53c1e8ad2c0194fe2b601ad9f181, compared to commit: 82d8883bfed8838e2078f3f631ebadb6b694a326

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
GenericEIP1967Migrator 121,763 (+12)

Comment thread doc/runbooks/single-deployments/any-chain/deploy-factory.md
@macroscopeapp
Copy link
Copy Markdown

macroscopeapp Bot commented Apr 13, 2026

Approvability

Verdict: Needs human review

1 blocking correctness issue found. Updates testnet factory addresses and simplifies the deployment script from CREATE2-based deployment to direct CREATE. While the changes are testnet-only configuration and script simplification, there's an unresolved documentation comment about an incorrect example that should be addressed before merging.

You can customize Macroscope's approvability policy. Learn more.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 13, 2026

LCOV of commit 7666914 during Solidity #781

Summary coverage rate:
  lines......: 99.9% (1366 of 1367 lines)
  functions..: 100.0% (387 of 387 functions)
  branches...: no data found

Files changed coverage rate: n/a

@fbac fbac merged commit 18152b8 into main Apr 13, 2026
14 checks passed
@fbac fbac deleted the fbac/deploy-upgradable-factories branch April 13, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant