Skip to content

Rename RunWitness to RunTranslator - #770

Merged
xmap merged 1 commit into
mainfrom
rename-run-witness-to-translator
Sep 3, 2026
Merged

Rename RunWitness to RunTranslator#770
xmap merged 1 commit into
mainfrom
rename-run-witness-to-translator

Conversation

@xmap

@xmap xmap commented Sep 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • RunWitness borrowed its name from the modeling axis it implements (ConductMode.WITNESSED, "who drove the act") rather than from what the agent itself does: translate an external tool's own vocabulary (TomoScan's free-text ScanStatus values) into CORA's canonical CapturePhase, then issue the matching Run command.
  • Per R5's actual test (name the agent for its own verb, not a category its output belongs to), RunTranslator is the correct name, and it stops reading as a fifth member of the unrelated Watcher family in the fleet roster.
  • Full rename: new seeded identity (AgentName is genesis-only immutable, so this is a fresh definition), the implementing runtime module/class (_run_witness.py -> _run_translator.py, RunWitnessRecorder -> RunTranslator), every run_witness.* log event -> run_translator.*, and every docstring/comment cross-reference that pointed at the old names.
  • RunWitness itself (seed_run_witness.py, RUN_WITNESS_AGENT_ID) stays source-tracked forever per its own FOREVER-STABLE rule, retired the same way the RunDebriefer/CautionDrafter legacy pair was.
  • Deliberately unchanged: the run_witness_enabled / run_witness_recording_enabled Settings fields and their env vars, since renaming those would silently change what a live deployment's existing configuration means.

Test plan

  • pytest tests/unit (52,019 passed)
  • pytest tests/architecture (fitness functions green)
  • pytest tests/integration (postgres, 1370 passed)
  • pytest tests/e2e (8 passed)
  • pyright clean
  • ruff check / ruff format --check clean
  • CI green
  • Live 2-BM migration after merge (seed RunTranslator, deprecate old RunWitness, verify no auth-mismatch warnings)

🤖 Generated with Claude Code

RunWitness borrowed its name from the modeling axis it implements
(ConductMode.WITNESSED, "who drove the act") rather than from what the
agent itself does: translate an external tool's own vocabulary
(TomoScan's free-text ScanStatus values) into CORA's canonical
CapturePhase, then issue the matching Run command. Per R5's actual
test (name the agent for its own verb, not a category its output
belongs to), RunTranslator is the correct name, and it stops reading
as a fifth member of the unrelated Watcher family in the fleet
roster.

Full rename: new seeded identity (RunTranslator, AgentName is
genesis-only immutable so this is a fresh definition, not an edit),
the implementing runtime module/class (_run_witness.py ->
_run_translator.py, RunWitnessRecorder -> RunTranslator), every
run_witness.* log event -> run_translator.*, and every docstring/
comment cross-reference that pointed at the old names. RunWitness
itself (seed_run_witness.py, RUN_WITNESS_AGENT_ID) stays source-
tracked forever per its own FOREVER-STABLE rule, retired as the
compile-time default the same way the RunDebriefer/CautionDrafter
legacy pair was.

Deliberately unchanged: the run_witness_enabled /
run_witness_recording_enabled Settings fields and their env vars,
since renaming those would silently change what a live deployment's
existing configuration means.
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  apps/api/src/cora/agent
  __init__.py
  _seeded_fleet.py
  seed_capture_progress_feeder.py
  seed_run_translator.py
  apps/api/src/cora/api
  _capture_scan_ingestor.py
  _run_translator.py 935-939, 981, 1043, 1074, 1136, 1138, 1186, 1450, 1462-1464, 1469
  _status_push.py
  in_process_grants.py
  main.py 1382-1394
  pilot_seed.py
  apps/api/src/cora/infrastructure
  config.py
  apps/api/src/cora/run
  wire.py
  apps/api/src/cora/run/aggregates/run
  state.py
  apps/api/src/cora/run/features/list_runs
  query.py
  apps/api/src/cora/run/features/record_witnessed_run
  handler.py
  apps/api/src/cora/run/features/record_witnessed_run_outcome
  decider.py
Project Total  

This report was generated by python-coverage-comment-action

@xmap
xmap merged commit e8513ec into main Sep 3, 2026
19 checks passed
@xmap
xmap deleted the rename-run-witness-to-translator branch September 3, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant