Skip to content

Remember project configs - #333

Merged
waruqi merged 2 commits into
xmake-io:devfrom
Meha555:fix/remember-configs
Jun 5, 2026
Merged

waruqi merged 2 commits into
xmake-io:devfrom
Meha555:fix/remember-configs

Conversation

@Meha555

@Meha555 Meha555 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor
  1. Remember the last selected target.
  2. Restore the last configured configs.

Fix #252, Fix #273

1. Remember the last selected target.
2. Restore the last configured configs.

Fix xmake-io#252, Fix xmake-io#273

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces target persistence using VS Code's workspace state and updates configuration initialization to respect in-memory options when they have changed. The review feedback highlights two issues: a potential runtime error or type mismatch if the toolchain option is not set in memory when keepChangedOptions is true, and an inconsistency where setting the target to undefined (defaulting to 'default') is not persisted to the workspace state.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/xmake.ts
Comment thread src/xmake.ts Outdated
Adjust configs checking logic.

Fix xmake-io#252, Fix xmake-io#273
@waruqi
waruqi merged commit dab8798 into xmake-io:dev Jun 5, 2026
6 checks passed
@Meha555
Meha555 deleted the fix/remember-configs branch June 5, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

记不住选择的toolchain 记住上次关闭时选中的target

2 participants