Skip to content

feat: activate extension for nested xmake projects when opening xmake.lua - #330

Open
Arteiimis wants to merge 4 commits into
xmake-io:devfrom
Arteiimis:dev
Open

feat: activate extension for nested xmake projects when opening xmake.lua#330
Arteiimis wants to merge 4 commits into
xmake-io:devfrom
Arteiimis:dev

Conversation

@Arteiimis

Copy link
Copy Markdown
  • Before adding new features and new modules, please go to issues to submit the relevant feature description first.
  • Write good commit messages and use the same coding conventions as the rest of the project.
  • Please commit code to dev branch and we will merge into master branch in feature
  • Ensure your edited codes with four spaces instead of TAB.

  • 增加新特性和新模块之前,请先到issues提交相关特性说明,经过讨论评估确认后,再进行相应的代码提交,避免做无用工作。
  • 编写友好可读的提交信息,并使用与工程代码相同的代码规范,代码请用4个空格字符代替tab缩进。
  • 请提交代码到dev分支,如果通过,我们会在特定时间合并到master分支上。
  • 为了规范化提交日志的格式,commit消息,不要用中文,请用英文描述。

@Arteiimis Arteiimis changed the title Dev fix: activate extension for nested xmake projects when opening xmake.lua Apr 5, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements automatic project root detection for the XMake extension by scanning the workspace and monitoring opened documents. Feedback suggests ensuring the XMake plugin state is fully refreshed when the root changes and making the root-switching logic more flexible for multi-root environments. Other recommendations include adding missing TypeScript type annotations and providing a functional link in the error message when XMake is not found.

Comment thread src/extension.ts Outdated
Comment thread src/extension.ts Outdated
Comment thread src/extension.ts Outdated
Comment thread src/extension.ts Outdated
Comment thread src/extension.ts Outdated
@Arteiimis Arteiimis changed the title fix: activate extension for nested xmake projects when opening xmake.lua feat: activate extension for nested xmake projects when opening xmake.lua Apr 5, 2026
Comment thread src/extension.ts Outdated
Comment thread src/extension.ts Outdated
@Arteiimis
Arteiimis requested a review from waruqi April 6, 2026 08:55
@waruqi

waruqi commented Apr 7, 2026

Copy link
Copy Markdown
Member

暂时不考虑这种切换模式,如果正好打开编辑了某个子目录 xmake.lua,但不是工程根目录 呢?而且这个 patch 里很多改动都跟这个特性无关,都混在一起,不是最小 patch。没法 review。

不要搞这种自动探测的,如果工程不在当前根目录,要么就加个配置,可以指定配置切到某个子目录作为根目录,通过配置的方式做可靠切换。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants