fix race condition during WriteStop #560
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangxie
force-pushed
the
race-condition
branch
from
1b3fb4e to
f74235c
Compare
Open
hangxie
force-pushed
the
race-condition
branch
from
f74235c to
d4e7281
Compare
hangxie
force-pushed
the
race-condition
branch
from
d4e7281 to
291845c
Compare
hangxie
force-pushed
the
race-condition
branch
from
291845c to
ee6122d
Compare
hangxie
force-pushed
the
race-condition
branch
2 times, most recently
from
f9fb536 to
91a1c46
Compare
Contributor
Author
|
@xitongsys would you please take a look at this PR? Two fixes included are pretty critical to address race conditions. Just in case you have concern on performance issue in the description - since the |
hangxie
force-pushed
the
race-condition
branch
from
91a1c46 to
6de3cb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #559, tested with my code.
This may not be the best fix, I didn't test performance penalty from this but since most Write are slow due to IO, I think we can live with it.