Merged
Conversation
added 2 commits
March 2, 2026 10:45
…d likely incorrectly overwiting 'mask_corners').
Reviewer's guide (collapsed on small PRs)Reviewer's GuideFixes a bug in bootstrap spectrum generation by correctly passing the polarization flag to dadi’s bootstrapping helper, and bumps the package version for release. Sequence diagram for bootstrap spectrum generation with polarized flagsequenceDiagram
participant User
participant CLI as dadi_cli.GenerateFs
participant Misc as dadi.Misc
User->>CLI: generate_fs(dd, chunk_size, bootstrap, pop_ids, projections, polarized)
CLI->>Misc: fragment_data_dict(dd, chunk_size)
Misc-->>CLI: fragments
CLI->>Misc: bootstraps_from_dd_chunks(fragments, bootstrap, pop_ids, projections, polarized=polarized)
Misc-->>CLI: bootstrap_list
loop for each fs in bootstrap_list
CLI->>CLI: optional marginalize_pops and processing
end
CLI-->>User: bootstrap frequency_spectra
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #136 +/- ##
==========================================
- Coverage 85.31% 85.13% -0.18%
==========================================
Files 27 27
Lines 1702 1702
==========================================
- Hits 1452 1449 -3
- Misses 250 253 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Fix handling of the polarization flag when generating bootstrap frequency spectra and bump the package patch version.
Bug Fixes:
Build: