Skip to content

Bootstrap fold bug#136

Merged
tjstruck merged 2 commits intomasterfrom
bootstrap_fold_bug
Mar 2, 2026
Merged

Bootstrap fold bug#136
tjstruck merged 2 commits intomasterfrom
bootstrap_fold_bug

Conversation

@tjstruck
Copy link
Collaborator

@tjstruck tjstruck commented Mar 2, 2026

Summary by Sourcery

Fix handling of the polarization flag when generating bootstrap frequency spectra and bump the package patch version.

Bug Fixes:

  • Ensure the polarized argument is correctly passed through to bootstrap frequency spectrum generation.

Build:

  • Bump the package version from 0.9.13 to 0.9.14.

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 2, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Fixes a bug in bootstrap spectrum generation by correctly passing the polarization flag to dadi’s bootstrapping helper, and bumps the package version for release.

Sequence diagram for bootstrap spectrum generation with polarized flag

sequenceDiagram
    participant User
    participant CLI as dadi_cli.GenerateFs
    participant Misc as dadi.Misc

    User->>CLI: generate_fs(dd, chunk_size, bootstrap, pop_ids, projections, polarized)
    CLI->>Misc: fragment_data_dict(dd, chunk_size)
    Misc-->>CLI: fragments
    CLI->>Misc: bootstraps_from_dd_chunks(fragments, bootstrap, pop_ids, projections, polarized=polarized)
    Misc-->>CLI: bootstrap_list
    loop for each fs in bootstrap_list
        CLI->>CLI: optional marginalize_pops and processing
    end
    CLI-->>User: bootstrap frequency_spectra
Loading

File-Level Changes

Change Details Files
Fix bootstrap generation to honor the polarized/unpolarized setting when creating bootstrapped frequency spectra.
  • Update the call to the bootstrapping helper to use a keyword argument for the polarization flag
  • Ensure that the polarized state from generate_fs is propagated into the bootstrapped data dictionaries
dadi_cli/GenerateFs.py
Prepare a patch release for the bugfix.
  • Increment the project version from 0.9.13 to 0.9.14
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.13%. Comparing base (99050d9) to head (ee373f2).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   85.31%   85.13%   -0.18%     
==========================================
  Files          27       27              
  Lines        1702     1702              
==========================================
- Hits         1452     1449       -3     
- Misses        250      253       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tjstruck tjstruck merged commit 124a77f into master Mar 2, 2026
6 of 7 checks passed
@tjstruck tjstruck deleted the bootstrap_fold_bug branch March 2, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant