ui: Add render scale and backend to compat reports #2319
Conversation
ui/xui/compat.cc
Outdated
| @@ -91,6 +87,23 @@ void CompatibilityReporter::Draw() | |||
| description[0] = '\x00'; | |||
| report.compat_comments = description; | |||
|
|
|||
| char render_scale_buffer[8]; | |||
| snprintf(render_scale_buffer, sizeof(render_scale_buffer), "%dx", | |||
| nv2a_get_surface_scale_factor() - 1); | |||
There was a problem hiding this comment.
Maybe copied from other UI code? The -1 elsewhere is for translating to lookup table, but here this will result in 0x being printed
There was a problem hiding this comment.
Yup, copied from UI code. Fixed.
ui/xui/reporting.hh
Outdated
| @@ -41,15 +41,17 @@ public: | |||
| std::string compat_rating; | |||
| std::string compat_comments; | |||
| std::string xbe_headers; | |||
| std::string rendering_scale; | |||
There was a problem hiding this comment.
Fixed, tabs once again.
ui/xui/reporting.cc
Outdated
| @@ -57,6 +49,8 @@ const std::string &CompatibilityReport::GetSerializedReport() | |||
| {"compat_rating", compat_rating}, | |||
| {"compat_comments", compat_comments}, | |||
| {"xbe_headers", xbe_headers}, | |||
| {"rendering_scale", rendering_scale}, | |||
There was a problem hiding this comment.
- Indentation doesn't match surrounding
- I'll have to update the backend to support saving these fields
There was a problem hiding this comment.
Weird, once again this looks fine in the GH UI for me. Looks like the file is using tabs. What do you have your tabs set to so I can catch these before they're a PR issue (at least until we run clang-format and get rid of them)?
There was a problem hiding this comment.
Huh, weird. GitHub on my end was showing a 1 space tab. Locally I usually use tab=4 spaces. Yeah, we'll clang-format and convert the tabs to spaces at some point.
abaire
force-pushed
the
add_res_scale_and_backend_to_compat
branch
from
8efaa98 to
bf0b93f
Compare
No description provided.