scripts: Add upload_bugtool.py #715
Conversation
dinhngtu
force-pushed
the
dnt/upload-bugtool
branch
2 times, most recently
from
631c30a to
ecfb82e
Compare
| def version_lt(a, b): | ||
| for ai, bi in zip_longest(a, b, fillvalue=0): | ||
| if ai < bi: | ||
| return True | ||
| elif ai > bi: | ||
| return False | ||
| return False |
There was a problem hiding this comment.
Why do we need this? Isn't this just a reimplementation of sequence comparison?
There was a problem hiding this comment.
No, they are not the same, as (3,0) < (3,0,0)
There was a problem hiding this comment.
What does it mean to say that 3.0 is not smaller than 3.0.0? Do you have cases where this is significant?
This is just for PLATFORM_VERSION...
There was a problem hiding this comment.
Is PLATFORM_VERSION variable length? You want 3.0 to equal 3.0.0 or version comparisons will break if PLATFORM_VERSION doesn't have the length you expect.
There was a problem hiding this comment.
I expect there will never be a case where this becomes a question, especially as with v9 we won't share a platform with XS any more, and we will have total control over that field. I think we're just file with comparing the tuple.
There was a problem hiding this comment.
Fine, either way works for me.
dinhngtu
force-pushed
the
dnt/upload-bugtool
branch
from
ecfb82e to
e82df1e
Compare
|
I'll merge soon if there are no more comments. |
| "--ciphers", | ||
| "ECDHE-RSA-AES256-SHA384,ECDHE-RSA-AES256-GCM-SHA384,AES256-SHA256,AES128-SHA256,ECDHE-ECDSA-AES128-GCM-SHA256", |
There was a problem hiding this comment.
Added explanatory comment.
Signed-off-by: Tu Dinh <[email protected]>
Signed-off-by: Tu Dinh <[email protected]>
dinhngtu
force-pushed
the
dnt/upload-bugtool
branch
from
d4b91c7 to
e4c9a97
Compare
Add a hybrid py2/py3 script for uploading bugtool archives to Nextcloud via a drop link.