Open
Conversation
…ption for debug/release
kaanolgu
commented
Nov 21, 2025
scripts/build.sh
Outdated
| fi | ||
|
|
||
| # PATHS | ||
| HOME_PATH="/scratch/hpc-prf-agraph" |
Collaborator
Author
There was a problem hiding this comment.
This should be edited by the user. What could be the best way to retrieve this information? a directory above the x3d2 folder maybe ?
… to be run via ./scripts/build.sh
ia267
requested changes
Dec 12, 2025
Collaborator
ia267
left a comment
There was a problem hiding this comment.
I don't think we should add this to the code repo:
- The
build.shcurrently requiresspackdir to be in a certain hardcoded dir - additional script changes needed to get it to work or moving of directories ifspacknot in the standard dir. - The
build.shdoesn't all all the cmake flags we have, we could add them, but if we add more flags we'll have to update the script. There's a risk that someone may unpdateCmakeLists.txtbut not update spack script - Most HPCs will have these packages installed, in which case it'll just be easier to just load modules and run the cmake command. The use case here is I guess for someone who wants to build on their own machine that may not have packages and will make it easier. I think for these users we could provide a README file
- Cloning spack repo (200MB) - extra friction even though you only do it once
I think it will be useful to add a section in contributor guide with an example for a combined GPU/CPU spack.yml file, and explaining how to use it - could save time for quick tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Spack environment based build bash script would help us to move between testbeds rapidly.
The prerequisites:
The usage:
The
[debug/release]is optional if nothing is provided it would be automatically Release