tab keyup behavior -- issue #114 #128
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to confirm selections in dropdown (that happens in the keydown event prior), only prevents tabbing between fields from firing search events via this switch's default clause . The user does not expect a search to happen and a dropdown to show up for a field they've already tabbed away from, or for a search to happen on the pre-existing value for a field that they tab into.
|
Hi @machinehum and thanks for the PR. Thanks a lot :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to not break standard HTML form tab key navigation behavior. DOES NOT affect using tab key to confirm selections in dropdown (that happens in the keydown event starting at line 209), only prevents tabbing between fields from firing search events via this switch's default clause.
Justification: The user does not expect a search to happen and a dropdown to show up for a field they've already tabbed away from, or for a search to happen on the pre-existing value for a field that they tab into. This fundamentally breaks standard browser behavior, and causes accessibility issues.