Skip to content

CP-308485: Force xcp-networkd to use only OVS #6620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BengangY
Copy link
Contributor

Use support-linux-bridge to determine if Linux bridge is supported.

If support-linux-bridge is true: Linux bridge is supported. networkd selects the network backend (OVS or bridge) based on /etc/xensource/network.conf.

If support-linux-bridge is false: networkd always uses OVS, regardless of the value in /etc/xensource/network.conf.

Set support-linux-bridge to false in XS 9 as XS 9 does not support Linux bridge.

@BengangY BengangY requested a review from MarkSymsCtx August 11, 2025 07:20
@BengangY BengangY force-pushed the private/bengangy/CP-308485 branch from 540a793 to f7d5662 Compare August 13, 2025 10:03
@BengangY BengangY marked this pull request as ready for review August 14, 2025 05:25
@BengangY BengangY requested a review from robhoes August 14, 2025 05:25
Use `support-linux-bridge` to determine if Linux bridge is supported.

If `support-linux-bridge` is `true`: Linux bridge is supported. `networkd`
selects the network backend (OVS or bridge) based on
`/etc/xensource/network.conf`.

If `support-linux-bridge` is `false`: `networkd` will fail if detecting
`bridge` in `/etc/xensource/network.conf`.

Set `support-linux-bridge` to `false` in XS 9 as XS 9 does not support Linux
bridge.

Signed-off-by: Bengang Yuan <[email protected]>
@BengangY BengangY force-pushed the private/bengangy/CP-308485 branch from f7d5662 to 59a01b6 Compare August 18, 2025 02:55
Copy link
Member

@psafont psafont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as there is a item tracking that the pre-checks need to make sure the bridge can't be linux, this change should be OK

@BengangY
Copy link
Contributor Author

As long as there is a item tracking that the pre-checks need to make sure the bridge can't be linux, this change should be OK

There is already a pre-check when upgrade from XS 8 to XS 9. Actually XS 9 will be reinstall when upgrade. So whatever the network backend is in XS 8, XS 9 will always choose OVS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants