Fix command type switching logic in joystick input#164
Open
Owhenthesaints wants to merge 1 commit intoxArm-Developer:jazzyfrom
Open
Fix command type switching logic in joystick input#164Owhenthesaints wants to merge 1 commit intoxArm-Developer:jazzyfrom
Owhenthesaints wants to merge 1 commit intoxArm-Developer:jazzyfrom
Conversation
Minor mistake. I think you meant to make the switch_input_, wait for service. And I think it is better to check the command_type before changing the command_type. I built these changes, and they work. I made this commit just to show a minor bug so I made this commit inline in the github web interface so please rebuild once just to check if there are any copy paste errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor mistake. I think you meant to make the switch_input_, wait for service. And I think it is better to check the command_type before changing the command_type.
I built these changes, and they work.
I made this commit just to show a minor bug so I made this commit inline in the github web interface so please rebuild once just to check if there are any copy paste errors.