Skip to content

ci: allow release comment job to view drafts - #270

Merged
robjtede merged 1 commit into
mainfrom
fix/draft-release-comment-permissions
Aug 9, 2026
Merged

ci: allow release comment job to view drafts#270
robjtede merged 1 commit into
mainfrom
fix/draft-release-comment-permissions

Conversation

@robjtede

@robjtede robjtede commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • grant the final release comment job write access to repository contents

Root cause

GitHub only includes draft releases in the releases list for callers with push access. The final comment job had only contents: read, so its API response omitted the draft release.

Validation

  • nix develop -c just check

Summary by CodeRabbit

  • Chores
    • Updated release automation permissions to support uploading release assets successfully.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The release workflow changes the release-assets-uploaded job permission from read-only to write access for repository contents.

Changes

Release workflow permissions

Layer / File(s) Summary
Enable release asset writes
.github/workflows/release.yml
The release-assets-uploaded job now has contents: write permission instead of contents: read.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the CI permission change that allows the release comment job to access draft releases.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/draft-release-comment-permissions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@robjtede
robjtede force-pushed the fix/draft-release-comment-permissions branch from 40db93b to 4098e21 Compare August 9, 2026 15:25
@robjtede robjtede changed the title fix: allow release comment job to view drafts ci: allow release comment job to view drafts Aug 9, 2026
@robjtede
robjtede merged commit ccddf2e into main Aug 9, 2026
8 checks passed
@robjtede
robjtede deleted the fix/draft-release-comment-permissions branch August 9, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant