-
-
Notifications
You must be signed in to change notification settings - Fork 365
fix(manifest): keep content_script
matches
unsorted
#1806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
content_script
matches
unsorted in manifestcontent_script
matches
unsorted
I'm good with this change as long it doesn't cause tests to become flakey in this repo (the only reason I sort everything lol, things start failing real fast if you don't ensure an order). Patching works, but if you don't want to deal with conflicts with the patch when upgrading WXT, you could use the |
Overview
I’ve noticed that URL patterns in
matches
end up being sorted. This affects what extension users see in the store, so sorting may be therefore undesired. For example, if we have, users will end up being presented with
That's somewhat less logical than the original sequence.
Manual Testing
I tested the changes locally via
pnpm patch
.Related Issue
I haven’t found or created one. The change is quite small so felt worth a PR right away. If you disagree with the idea, feel free to ignore this change.
pnpm patch
gives a good enough workaround, so the issue is not blocking.PS: Pretty impressed with
wxt
, great project!